CircuitVerse / mobile-app

Mobile App for CircuitVerse
https://play.google.com/store/apps/details?id=org.circuitverse.mobile_app
MIT License
73 stars 94 forks source link

Updated state management of floating buttons in Interactive book #254

Closed tanmoysrt closed 1 year ago

tanmoysrt commented 1 year ago

Fixes #251

Describe the changes you have made in this PR - I have updated the state management from tradition setstate to Provider.

This fix solve which things

Screenshots of the changes (If any) -

A screen recording after updating

https://user-images.githubusercontent.com/57363826/211865395-4056b4af-ee5e-4382-ac2f-8a9031759c5c.mp4

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

tanmoysrt commented 1 year ago

@aman-singh7 @manjotsidhu can you take some time to review this PR. Thank You

tanmoysrt commented 1 year ago

@aman-singh7 can you check once is the pipeline broken? I can't find any issue with the updated part also it doesn't fail in flutter analyze.

aman-singh7 commented 1 year ago

@aman-singh7 can you check once is the pipeline broken? I can't find any issue with the updated part also it doesn't fail in flutter analyze.

Let me see. Are you using the latest flutter version??

tanmoysrt commented 1 year ago

@aman-singh7 can you check once is the pipeline broken? I can't find any issue with the updated part also it doesn't fail in flutter analyze.

Let me see. Are you using the latest flutter version??

yes, I have not pushed any pubspec update or dart version upgrade

tanmoysrt commented 1 year ago

@aman-singh7 can you check it once. I have done the said changes.

tanmoysrt commented 1 year ago

@aman-singh7 @manjotsidhu if you have got some time, please review the PR

tanmoysrt commented 1 year ago

@aman-singh7 @manjotsidhu ig we need to resolve the deprecation warning. else flutter analyze is failing

manjotsidhu commented 1 year ago

@Tanmoy741127 I have rerun the checks, flutter analyze is still failing

tanmoysrt commented 1 year ago

@manjotsidhu ig I need to merge the code from latest commit

manjotsidhu commented 1 year ago

@Tanmoy741127 Yeah, you can rebase your changes against master

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4331897463


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/viewmodels/ib/ib_floating_button_state.dart 3 6 50.0%
lib/ui/views/ib/ib_page_view.dart 20 35 57.14%
<!-- Total: 23 41 56.1% -->
Totals Coverage Status
Change from base Build 4318007970: -0.0008%
Covered Lines: 4049
Relevant Lines: 6265

💛 - Coveralls