[fix#269] Removed Load more button from featured circuits page

danger-ahead commented 1 year ago

Fixes #269

Describe the changes you have made in this PR -

[x] Removed Load more button from featured circuits page
[x] Added Loading animation while loading the circuits

Screenshots of the changes (If any) -

simplescreenrecorder-2023-03-02_03.48.19.webm

danger-ahead commented 1 year ago

Looks fine . I think it's not formatted. Kindly format the code by dart format .

Hey it's already formatted. Check the reason why the build failed. There were multiple deprecation warnings. I will open an issue shortly for this and fix the warnings.

tanmoysrt commented 1 year ago

@tachyons can you run the workflow again

tanmoysrt commented 1 year ago

@danger-ahead please merge your code with latest commits in main branch. As the old code consists some deprecation that has been fixed in latest update

danger-ahead commented 1 year ago

@danger-ahead please merge your code with latest commits in main branch. As the old code consists some deprecation that has been fixed in latest update

@Tanmoy741127 Pushed after merging with master. Have a look!

tanmoysrt commented 1 year ago

@vedant-jain03 @tachyons can you run the workflow

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4329816200

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 64.618%

Totals
Change from base Build 4318007970:	-0.01%
Covered Lines:	4047
Relevant Lines:	6263

Pull Request Test Coverage Report for Build 4329816200

11 of 19 (57.89%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 64.618%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/ui/views/projects/featured_projects_view.dart	11	19	57.89%
<!--	Total:	11	19	57.89%	-->

Totals
Change from base Build 4318007970:	-0.01%
Covered Lines:	4047
Relevant Lines:	6263

💛 - Coveralls

manjotsidhu commented 1 year ago

@danger-ahead Can we show loader when next set of circuits are being loaded ?

manjotsidhu commented 1 year ago

Also, please rebase your branch to pass CI checks

danger-ahead commented 1 year ago

simplescreenrecorder-2023-03-05_07.55.19.webm

@vedant-jain03 @Tanmoy741127 @manjotsidhu Added loader while the next batch of circuits is being loaded. Have a look!

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4333926445

-8 of 24 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 64.635%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/ui/views/projects/featured_projects_view.dart	16	24	66.67%
<!--	Total:	16	24	66.67%	-->

Totals
Change from base Build 4318007970:	0.005%
Covered Lines:	4050
Relevant Lines:	6266

Pull Request Test Coverage Report for Build 4333926445

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

16 of 24 (66.67%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.005%) to 64.635%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/ui/views/projects/featured_projects_view.dart	16	24	66.67%
<!--	Total:	16	24	66.67%	-->

Totals
Change from base Build 4318007970:	0.005%
Covered Lines:	4050
Relevant Lines:	6266

CircuitVerse / mobile-app