search

Circuitscape / Circuitscape.py

Circuitscape uses electronic circuit theory to solve problems in landscape ecology.
https://www.circuitscape.org/
Other
27 stars 17 forks source link

Updates to gui for win32 #60

Closed bmcrae closed 10 years ago

bmcrae commented 10 years ago

Changes to gui to allow executable on win 32. Fixes #57.

Using os.path.dirname(__file__) to locate the current directory was returning a location within library.zip, which caused problems on win32. I've made changes for the logo and verify code. @tanmaykm, please check to see if this causes any problems on Mac platform.

tanmaykm commented 10 years ago

The two lines of code in line 104:

_icon = wx.Icon('cs_logo.ico', wx.BITMAP_TYPE_ICO)
self.SetIcon(_icon)

are causing problem on mac. I believe they are windows only?

Other than that everything else looks good to me.

bmcrae commented 10 years ago

Odd... I hadn't changed those lines.

OK to go ahead and merge? Anything we need to do about the icon?

tanmaykm commented 10 years ago

Yes you are right. Those two lines were part of this: https://github.com/Circuitscape/Circuitscape/commit/94b9ab9f5bb653dea2f9d3aa7580993e9d040650. I'll merge this and push a separate commit for that.

bmcrae commented 10 years ago

I had totally forgotten making that change. Thanks for catching that.