Closed NCrashed closed 10 years ago
I have to say I'm very impressed with this. I'm a huge fan of the quality of code here.
The only question I have is about how the Output vs. Logging works. Does a call to the log()
function handle both the stdio logging and the file logging (assuming verbosity is proper)?
There is actually two log
functions:
Deprecated one (old behavior, prints to console only)
void log( A... )( OutputType type, A messages )
Logger one that actually should be used:
void log( A... )( LoggingLevel type, lazy A messages )
Last function prints to console and to file simultaneously . There is two parameters in logger to control output behavior:
minOutputLevel
- handles minimal LoggingLevel
values that goes to consoleminLoggingLevel
- handles minimal LoggingLevel
values that goes to fileOkay. The part where it prints to the console and to the file was the part I was curious about.
Having looked over all of the code, I can say LGTM :+1:
Awesome stuff, this will make both the engine and game folks happier.
Looks great man. Awesome turnaround. :+1:
I found that my dlogg package also uses logInfo and logError
names for wrappers.
Deprecating the names here also implies deprecating dlogg API (that affect a ton of code), I haven't yet decided how to synchronize wrappers names with loggging level names in the best way. Perhaps it just not a good idea.
In that case, I think it's fine to keep them.
Looks good! :+1:
Original issue: https://github.com/Circular-Studios/Dash/issues/149