search

CirrusLogic / tinyhal

Configurable audio HAL for Android
Apache License 2.0
32 stars 17 forks source link

Merge tinyhal with audio HAL from AOSP/yukawa project #13

Closed rsglobal closed 2 years ago

rsglobal commented 2 years ago

Hi @rfvirgil ,

New AOSP VTS checks start to encourage me to use HAL v7.0 or v7.1, but tinyhal doesn't implement some APIs which is mandatory for v7+.

Will you accept such merge (splitted into small patches) if I will do it? I'm asking now because I don't want to spend weeks working on it without confirmation from your end.

Ideal for me is to take audio_hw.* code from yukawa and use config manager from tinyhal. (keeping minimalistic difference with the yukawa). Thus we can simply apply fixes/features from yukawa, which will make long-term support very easy.

PS: yukawa audio HAL is maintained by the guys from Google.

rfvirgil commented 2 years ago

You can use the tinyhal configmgr from a different audio HAL It was deliberately split out into a separate library so you can use it stand-alone.

So you if have an audio HAL in another component, you can keep that separate from tinyhal and import the tinyhal configmgr.

However, if you want to submit changes to the tinyhal audio HAL to upgrade it to latest APIs we are willing to accept that.

rsglobal commented 2 years ago

@rfvirgil ,

Thank you for suggestions. I opened a PR: https://github.com/CirrusLogic/tinyhal/pull/15