search

CirrusLogic / tinyhal

Configurable audio HAL for Android
Apache License 2.0
31 stars 17 forks source link

configmgr: fix missing mixer_update_ctls() method #3

Closed aleksander0m closed 6 years ago

aleksander0m commented 7 years ago

Commit fd3290357ea02f871a10eec208697fb97d578fe6 in tinyalsa introduced a new mixer_add_new_ctls() method, and tinyhal was instead depending on the old name given to it during development, mixer_update_ctls().

E.g.: device/linaro/generic/audio/audio_config.c:337:9: error: implicit declaration of function 'mixer_update_ctls' is invalid in C99 [-Werror,-Wimplicit-function-declaration] mixer_update_ctls(cm->mixer); ^ device/linaro/generic/audio/audio_config.c:337:9: note: did you mean 'mixer_add_new_ctls'? external/tinyalsa/include/tinyalsa/mixer.h:75:5: note: 'mixer_add_new_ctls' declared here int mixer_add_new_ctls(struct mixer *mixer); ^ 1 error generated. ninja: build stopped: subcommand failed. build/core/ninja.mk:148: recipe for target 'ninja_wrapper' failed make: *** [ninja_wrapper] Error 1

rfvirgil commented 6 years ago

I already did a patch to fix this same thing and I've pushed my version to keep github in sync with our internal repos. So this pull request can be abandoned.