allow ssh key option - Githubissues

Cisco-SAN / mdssdk

Python SDK/API library for Cisco MDS Switches

Other

5 stars 15 forks source link

allow ssh key option #11

Closed wardy3 closed 3 years ago

wardy3 commented 3 years ago

[x] allow ssh key file to be provided instead of password
[ ] write tests for passwordless access

closes #9

srbharadwaj commented 3 years ago

Can you please add an example for the same?

srbharadwaj commented 3 years ago

Also if u dont mind, give me a week's time i will commit this change along with some other changes when NXOS 9.2(1) gets released

srbharadwaj commented 3 years ago

Can pick the code from here and see if key_file is working as expected? https://github.com/srbharadwaj/mdssdk?organization=srbharadwaj&organization=srbharadwaj

wardy3 commented 3 years ago

Not sure how you fix that type of thing on a public repo. I normally push -f after a rebase. I’ll add new commits and I suppose we just squash them in this case?

srbharadwaj commented 3 years ago

@wardy3 Closing this PR as the latest release v1.3.0 should support this feature, please test it out and let me know

wardy3 commented 3 years ago

@wardy3 Closing this PR as the latest release v1.3.0 should support this feature, please test it out and let me know

looks good. thanks!