Cisco-SAN / mdssdk

Python SDK/API library for Cisco MDS Switches
Other
5 stars 15 forks source link

Remove multiple NPV feature request #29

Closed Le-Syl21 closed 1 year ago

Le-Syl21 commented 1 year ago

Etch time you create a Zone Object you ask switch if NPV feature is on. This code ask only first time then keep it in mind. It clearly accelerate execution.

srbharadwaj commented 1 year ago

@Le-Syl21 Thanks for the good suggestion. Shouldn't the code here be self.__npv = self.npv

Le-Syl21 commented 1 year ago

I let you do as you wish.

Can you add a zone rename def?

Le mer. 9 nov. 2022, 11:30, Suhas Bharadwaj @.***> a écrit :

Thanks for the good suggestion. Shouldn't the code here be self.__npv = self.npv

— Reply to this email directly, view it on GitHub https://github.com/Cisco-SAN/mdssdk/pull/29#issuecomment-1308541665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCM3FU4S4TZNMANPXBCEMTWHN4MBANCNFSM6AAAAAARXE6S3M . You are receiving this because you authored the thread.Message ID: @.***>

srbharadwaj commented 1 year ago

I let you do as you wish. Can you add a zone rename def? Le mer. 9 nov. 2022, 11:30, Suhas Bharadwaj @.> a écrit : Thanks for the good suggestion. Shouldn't the code here be self.__npv = self.npv — Reply to this email directly, view it on GitHub <#29 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCM3FU4S4TZNMANPXBCEMTWHN4MBANCNFSM6AAAAAARXE6S3M . You are receiving this because you authored the thread.Message ID: @.>

Sure please add a enhancement bug

Le-Syl21 commented 1 year ago

Done thx

Le mer. 9 nov. 2022, 11:38, Suhas Bharadwaj @.***> a écrit :

I let you do as you wish. Can you add a zone rename def? Le mer. 9 nov. 2022, 11:30, Suhas Bharadwaj @.

> a écrit : … <#m2353489825882578098> Thanks for the good suggestion. Shouldn't the code here be self.__npv = self.npv — Reply to this email directly, view it on GitHub <#29 (comment) https://github.com/Cisco-SAN/mdssdk/pull/29#issuecomment-1308541665>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCM3FU4S4TZNMANPXBCEMTWHN4MBANCNFSM6AAAAAARXE6S3M https://github.com/notifications/unsubscribe-auth/AQCM3FU4S4TZNMANPXBCEMTWHN4MBANCNFSM6AAAAAARXE6S3M . You are receiving this because you authored the thread.Message ID: @.>

Sure please add a enhancement bug

— Reply to this email directly, view it on GitHub https://github.com/Cisco-SAN/mdssdk/pull/29#issuecomment-1308551416, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQCM3FRN5RUGEHCVVWB5E53WHN5LNANCNFSM6AAAAAARXE6S3M . You are receiving this because you were mentioned.Message ID: @.***>