Cisco-Talos / clamav-docker

Dockerfiles for the ClamAV project
38 stars 21 forks source link

Issues with entrypoing logging #18

Open stavros-k opened 1 year ago

stavros-k commented 1 year ago

There is a log line in the entrypoint that it's supposed to overwrite the line with the new info. From my testing that's not happening. I discovered it cause some CI runs testing a kubernetes deployment was never ending. Tried and reproduced it locally, and the only time this was happening was when the clamd socket was a bit late to startup.

Looking into the logs, looks like it was printing everything into a single line, causing logs exceed what a lot of kubernetes tools "accept" as a normal line size.

For example, native kubectl command to get logs, it was "replaying" the logs showing the overwrite happening in fast forward. ct install (helm's testing tool) wasn't happy about this. k9s also wasn't happy. When I tried to wrap the logs lines it was freezing up.

etcd on k8s have a limit of 1MiB for every object. which is most likely what's causing the problem here. https://github.com/kubernetes/kubernetes/issues/19781

Please consider instead of overwriting the line to just print it on a new line.

The line in question: https://github.com/Cisco-Talos/clamav-docker/blob/4f093e052a24843fbbc1f1f58e60af43897284f5/clamav/1.0/debian/scripts/docker-entrypoint.sh#L70

Thanks

stavros-k commented 1 year ago

Just saw a PR addressing it https://github.com/Cisco-Talos/clamav-docker/pull/16