search

Cisco-Talos / clamav-docker

Dockerfiles for the ClamAV project
38 stars 21 forks source link

Debian and Alpine built with the same tags #5

Closed avishefi closed 8 months ago

avishefi commented 1 year ago

The Jenkinsfiles look the same, and there are no different tags on Docker Hub for either Alpine or Debian.

barborico commented 1 year ago

+1 The Jenkinsfiles for debian specifically pull the alpine Dockerfiles and scripts; see e.g. https://github.com/Cisco-Talos/clamav-docker/blob/fdc41e9d0a3833e39e0c4a2fb3d56da0c01ebdb2/clamav/1.0/debian/Jenkinsfile#L50.

JonBendtsen commented 1 year ago

Attempted to fix in https://github.com/Cisco-Talos/clamav-docker/pull/11, but I'm just a regular user as well, so who knows if my proposed fix is okay and when it might or might not be approved.

micahsnyder commented 1 year ago

Thanks for the fix to the Jenkinsfiles @JonBendtsen. That was indeed an issue,

Right now we have Jenkinsfiles and supporting scripts for Debian, but we aren't yet building or publishing them. That's still a work in progress. When it's stable, we'll publish them to https://registry.hub.docker.com/r/clamav/clamav-debian (clamav/clamav-debian).

Until then, the only images we publish (at clamav/clamav) are based on Alpine.

Some day, I think we may switch the main image from Alpine to Debian as well. But we don't have a specific date in mind. We'll have to schedule and announce the plans to the ClamAV community far in advance to make sure that goes smoothly.

avishefi commented 1 year ago

@micahsnyder I see #11 is merged, can't we use it to create additional tags on clamav/clamav?

micahsnyder commented 1 year ago

@micahsnyder I see #11 is merged, can't we use it to create additional tags on clamav/clamav?

We don't publish debian-based images to clamav/clamav yet, so that wouldn't make any sense. We ought to start publishing them to clamav/clamav-debian as I mentioned yesterday. With the fix you made I think it may be good to go. .

rsundriyal commented 8 months ago

As per the last merge #33, we now publish separate image tags for the Alpine and Debian images.

Please go through the README.md for more details about images/repos/tags.

As the issue is now obsolete, I am closing the issue.