Open jmlrt opened 6 months ago
I agree, it would be nice if clamav's config files would support inline comments.
Here is an attempt at a solution. I've tested it locally by manually editing the clamd.conf
file and I'm open to suggestions in case you see anything that should be improved/changed. Hope it helps.
The first issue I see is that inline comments are not accepted due to failed Regex checks. This would be the case for MATCH_NUMBER
, MATCH_SIZE
and MATCH_BOOL
because of the end line assertion $
not allowing for anything (comment in this case) between the value and the end of the line. Because of it, lines with an inline comment fail the check that is done here.
In case we fix the Regex expression, we would need to account for the inline comments in the following switch
/case
branches (I've accounted for them right before the switch so we don't have code repetition). The approach I took was to check if the value of the argument contains the #
character and in case it does, use strtok
to get the content on its left side.
Describe the bug
Clamd start is failing when some comment are added on the same line as a config value in the
clamd.conf
file.How to reproduce the problem
Edit
clamd.conf
and addMaxRecursion 20 # set to 20
for example.Move the inline comment to its own line and it's starting again:
Attachments
If applicable, add screenshots to help explain your problem.
If the issue is reproducible only when scanning a specific file, attach it to the ticket.