Clam 2612 Fix DatabaseCustomURL CVD prune bug, and add 'valhalla' optional database - Githubissues

Cisco-Talos / clamav

ClamAV - Documentation is here: https://docs.clamav.net

https://www.clamav.net/

GNU General Public License v2.0

4.43k stars 706 forks source link

Clam 2612 Fix DatabaseCustomURL CVD prune bug, and add 'valhalla' optional database #1233

Closed micahsnyder closed 7 months ago

micahsnyder commented 7 months ago

Freshclam: fix issue DatabaseCustomURL CVD prune issue

If using DatabaseCustomURL to download a CVD that Freshclam doesn't know about, i.e. one that is not in the hardcoded standard or optional database lists in freshclam.c, Freshclam will prune the database and then re-download it.

This change makes it so we look for URL's with ".cvd" at the end and then take those into consideration when checking which CVD's (or CLD's) should be pruned.

Note that I didn't change the interface to fc_prune_database_directory(). That would have been cleaner, but would've changed the public API and I want to backport this fix.
Add 'valhalla' to Freshclam's list of optional CVD's

ragusaa commented 7 months ago

Testing passed

micahsnyder commented 7 months ago

Oops. There's a windows build issue:

freshclam.c.obj : error LNK2019: unresolved external symbol strndup referenced in function perform_database_update

I'll fix it.