search

Cisco-Talos / clamav

ClamAV - Documentation is here: https://docs.clamav.net
https://www.clamav.net/
GNU General Public License v2.0
4.43k stars 706 forks source link

[Bug]: 1.3.x - Build failures on x32 due to onenote.rs #1286

Closed Kangie closed 1 month ago

Kangie commented 4 months ago 
FAILED: armv7-unknown-linux-gnueabihf/release/libclamav_rust.a /var/tmp/portage/app-antivirus/clamav-1.3.0/work/clamav-clamav-1.3.0_build/armv7-unknown-linux-gnueabihf/release/libclamav_rust.a 
error: literal out of range for `isize`

How to reproduce the problem

Attempt to build on an x32 platform (arm, x86, ppc, etc)

Fix

Fix already submitted upstream, issue raised to track on ClamAV side.

https://github.com/msiemens/onenote.rs/pull/14

Gentoo Ticket: https://bugs.gentoo.org/927214

micahsnyder commented 4 months ago

We've been using a fork of the onenote-rs library while waiting for activity on our own PR. This is the branch: https://github.com/msiemens/onenote.rs/compare/master...Cisco-Talos:onenote.rs:CLAM-2329-new-from-slice

We could cherry-pick your commit onto that branch as well. I'm holding out hope that we don't need to fork the onenote-rs project and give it a new name, version, etc.

Kangie commented 4 months ago

I think you're going to need to. No activity upstream since you submitted your PR. :(

edit: we're patching downstream, however it'd be fantastic if we could treat this as a blocker for the next release - either upstream has made appropriate changes or we update the git crate and can close this off. :)

Kangie commented 1 month ago

The git crate was updated. Thanks @micahsnyder