fix: Attempt to create log file if it does not exist. - Githubissues

Cisco-Talos / clamav

ClamAV - Documentation is here: https://docs.clamav.net

https://www.clamav.net/

GNU General Public License v2.0

4.43k stars 706 forks source link

fix: Attempt to create log file if it does not exist. #1322

Open userwiths opened 3 months ago

userwiths commented 3 months ago

Fixes: #1155 It might seem a bit messy but the gist of the PR is that.

We introduce fc_upsert_logg_file method, which attempts to create the directories & log file as required.
We move the drop_privileges case/branch later during the execution. If we do this before we fc_upsert_logg_file our log file, then we can't use root privileges even if freshclam is started as root.
In order to chown the directories (and file, overkill?) we introduce the field dbOwner in the fc_config structure.

Seems this has been handled in documentation as a step of the setup.

userwiths commented 2 months ago

@micahsnyder tagging you cause this might have been forgotten. Managed to get the CI all green and put it in review. Just a reminder.