search

Cisco-Talos / cvdupdate

ClamAV Private Database Mirror Updater Tool
Apache License 2.0
93 stars 35 forks source link

Cvd continues even if main signatures is missing #35

Closed brentclark closed 2 years ago

brentclark commented 2 years ago

Good day I would like to report and make a pull request for cvdupdate.

What we found is. If the main / actual signature is missing (i.e. accidentally and manually removed) from the db dir, cvdupdate just continue with the cdiff(s) and ignore the fact that the main is missing. This work will first ensure and download the main signature.

You can find the example here: https://pastebin.com/raw/Kg4YZ6AM

Please will you consider my pull request to ensure signature integrity.

Many thanks Kind Regards Brent Clark

sl0m0ZA commented 2 years ago

This is a good update and will ensure that the signature is pulled and checked.

brentclark commented 2 years ago

Thanks Can you look now please.

micahsnyder commented 2 years ago

I see you addressed the issues I was concerned with from https://github.com/Cisco-Talos/cvdupdate/pull/34 in this PR. I just did some testing and it looks good. A different PR caused a big merge conflict, so I rebased your branch and fixed the conflict for you. I wasn't about to ask you to make changes again after I made you wait so long for this re-review.

Thank you for your patience and your contribution.