Cisco-Talos / cvdupdate

ClamAV Private Database Mirror Updater Tool
Apache License 2.0
93 stars 35 forks source link

update pypi version of cvdupdate to include patch for DNS TXT query issue #42

Closed dholiday-splunk closed 2 years ago

dholiday-splunk commented 2 years ago

Please push the latest stable build to pypi so users of cvdupdate can use pypi to get the patched version.

ty 🍻 😃

micahsnyder commented 2 years ago

Thanks for the reminder! So sorry this sat for ages. I had this idea I'd figure out the windows compatibility issue, then got distracted... and... well... Anyways. Lesson learned.

Just published: https://github.com/Cisco-Talos/cvdupdate/runs/6463631148?check_suite_focus=true https://pypi.org/project/cvdupdate/

dholiday-splunk commented 2 years ago

w00t - ty!! 🍺

dholiday-splunk commented 2 years ago

FYI for anyone endeavoring to run cvdupdate inside a docker container and running into the DNS TXT query issue - if you're running a version that's been patched for the aforementioned and still seeing the issue, you can instruct cvdupdate to use google's DNS server 8.8.8.8 with an environment variable.

I added the following to my docker file and that got things rolling

ENV CVDUPDATE_NAMESERVER="8.8.8.8"

Note that using the --dns argument when invoking docker run did not work. My hypothesis is that cvdupdate is looking to /etc/resolv.conf to determine where the DNS server is and that file is one that Docker will manipulate on container creation to ensure container networking is setup.

🍺