Closed nyanshak closed 8 years ago
Yeah, sorry that's confusing behavior! It does run a few tests that don't pass in a Docker container. As noted in the comment in the Dockerfile, its not really suited to running in a container in the first place. I'll try and make some tests that pass in that container since that behavior would make more sense.
Would that entail simply removing tests or making the existing tests pass? If you need help with this, I can submit a pull request.
@nyanshak That would be spectacular! Yeah, if you just want to create a new file like samples/alpine-docker.json
with tests that will pass in that container, that'd be perfect. The files that are currently in samples
are just examples, not really meant to necessarily pass.
Fixed in 37277db
Doing a
docker run
on the included Dockerfile shows failing tests. The same occurs upon attemptinggo test
within /bin/sh of the docker container.Expected: Passing tests? Actual: (docker build and run)
(
docker run -it $img /bin/sh
, followed bygo test
)I believe this stems from specific files and / or executables missing from the gliderlabs/alpine:3.2 image that are expected by the tests in this package. For example bash is expected to exist as well as certain other mountpoints (/opt). I haven't done a full dive into this yet, but if this is something that you'd like to pursue, I can probably submit a PR in the next few days.