search

CiscoCloud / distributive

Unit testing for the cloud
Apache License 2.0
147 stars 20 forks source link

Sample checklists should all work in Docker #106

Closed langston-barrett closed 8 years ago

langston-barrett commented 8 years ago

As per issue #101 and PR #105, it is unexpected behavior when the sample checklists didn't work in the provided Dockerfile. We should make all samples work in this environment. This also provides another way to test Distributive before releases.

nyanshak commented 8 years ago

@siddharthist, I actually have a decent idea already of how to make some of these checks work, so let me know if I can help out here.

The checks that will likely be the most difficult will be the systemctl.json (systemd) checks, as alpine doesn't seem to support it. Perhaps for testing purposes, it might make sense to switch to a system with systemd running by default (debian:jessie, ubuntu, etc)?

nyanshak commented 8 years ago

Actually, wrt the issue about init systems, I think the problem is a bit harder than I first suspected. Maybe it would be better to make a (more) generic check for init systems by examining PID 1? I'm not sure.

Edit: some light reading about this: https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/ :whale:

langston-barrett commented 8 years ago

@nyanshak Let's not worry about systemd checks right now, it'd be awesome if you could help with the other ones if you think it'd be easy enough!