CiscoCloud / distributive

Unit testing for the cloud
Apache License 2.0
147 stars 20 forks source link

packages check - not parsing parameters #27

Closed noahjl closed 9 years ago

noahjl commented 9 years ago

Validating some of the checks and noticing a consistent fail for repoExists checks -

{
    "Name": "chronos health check",
    "Notes": "For use with Microservice Infrastructure",
    "Checklist" : [
        {
            "Name": "mesosphere repo present in yum",
            "Check": "repoExistsURI",
            "Parameters": ["yum","http://repos.mesosphere.io/el/7/noarch/"]
        },
....

based on packages.go it seems that the baseurl or name in /etc/yum.repos.d/mesosphere.repo should fit the parameters. But they return errors:

Repo with given Url not found:
        Specified: http://repos.mesosphere.io/el/7/$basearch/
        Actual: []

Using repoExists and the "name=" in mesosphere.repo

Repo with given Name not found:
        Specified: Mesosphere Packages for EL 7 - noarch
        Actual: []

Using the microservices-infrastructure vagrant box for testing.

I've also installed the RPM of distributive 0.1.

langston-barrett commented 9 years ago

Awesome, thanks for testing! This one is particularly difficult, as I don't really have three package managers on my system. In fact, the code is only looking through /etc/yum.conf. Can you send me both your /etc/yum.conf and /etc/yum.repos.d?

langston-barrett commented 9 years ago

TODO: Improve repo check to read from information outputted by yum & deb.

langston-barrett commented 9 years ago

Fixed by ca099df4a606531607b7d25bc5e8d8b70bc3e0ba