search

CiscoCloud / distributive

Unit testing for the cloud
Apache License 2.0
147 stars 20 forks source link

Port not working if it's udp #81

Closed orimarti closed 8 years ago

orimarti commented 8 years ago

The "port" check works fine with TCP ports, but if I want to check if there is some listening UDP port it doesn't work. Maybe this should check /proc/net/udp too

langston-barrett commented 8 years ago

Good thought! I'll work on this when I can, but if you'd like to put in a PR, I'd be happy to merge it. Look here for the relevant code: https://github.com/CiscoCloud/distributive/blob/master/workers/network.go#L18

orimarti commented 8 years ago

OK, I'll put in a PR when I'll have some time. Thx!!

orimarti commented 8 years ago

Hey @siddharthist , I'm compiling the code but the resulting binary it's returning 0 in all cases. Is there any thing to take in consideration when compiling the code?

Thx!

langston-barrett commented 8 years ago

Nope! I just use go build. I think you may be stumbling upon a separate bug... I'll try and track that one down today. Try using --verbosity=info to get relevant messages.

langston-barrett commented 8 years ago

I found the issue, and have fixed it in my most recent commit to master :smile:

orimarti commented 8 years ago

Thanks!! :)

orimarti commented 8 years ago

PR done! :)

langston-barrett commented 8 years ago

Closed by PR #85