search

CiscoCloud / haproxy-consul

Dynamic haproxy configuration using consul
Apache License 2.0
168 stars 85 forks source link

Check conf before restart #30

Open auguster opened 8 years ago

auguster commented 8 years ago

I just had a nasty crash of haproxy-consul because the data coming from consul led to a bad haproxy.cfg file. This caused haproxy to crash on restart, stopping the container.

I would be nice if haproxy-consul could check the config file (using haproxy -f /haproxy/haproxy.cfg -c) and if it's clean, only then restart haproxy. I would make the overall more robust and more trustworthy ;-)

lalarsson commented 8 years ago

Your wish has been brought into existence in PR #37 :)

auguster commented 8 years ago

@lalarsson thanks, looking forward seeing this merged ;-)

lalarsson commented 8 years ago

@auguster: @stevendborrelli have just merged it :)