CiscoCloud / haproxy-consul

Dynamic haproxy configuration using consul
Apache License 2.0
168 stars 85 forks source link

Feature/haproxy docs #7

Closed BrianHicks closed 9 years ago

BrianHicks commented 9 years ago

Looking for feedback from anyone, especially @npateriya.

npateriya commented 9 years ago

I will add one more sample/example in that folder, for example mysql tcp load balancing, assuming below is right you can add same or fix it before adding. This will make shipped team clear on shipped related use case:

{
  "container": {
    "type": "DOCKER",
    "docker": {
      "image": "mysql",
      "network": "BRIDGE",
      "portMappings": [
        {
          "containerPort": 3306,
          "protocol": "tcp"
        }
      ]
    }
  },
  "id": "shipped-api-mysql",
  "instances": 1,
  "cpus": 1,
  "mem": 1024,
  "ports": [0]
  "env": {
    "MYSQL_ROOT_PASSWORD": "*****",
  }
}
BrianHicks commented 9 years ago

yeah, that looks right to me. "ports": [0] is implicit when you don't set that field, but you're right that it should be explicit here.