search

CiscoCloud / marathon-consul

bridge Marathon information to Consul KV
Apache License 2.0
85 stars 18 forks source link

/health endpoint not working #18

Open davidsayers opened 8 years ago

davidsayers commented 8 years ago

The http://0.0.0.0:4000/health endpoint is not working in the latest version.

I guess it is less important since /events is used instead of a subscription with newer versions of marathon. However it would be nice to know about the health of the container. This would match mesos-consul which had a health check added.

bwhaley commented 8 years ago

+1 In fact I'm seeing that the port is never opened. --listen has no effect.

rrichardson commented 8 years ago

I see the same issue. Anyone find a solution to this?

rrichardson commented 8 years ago

It looks like the issue is here:
https://github.com/CiscoCloud/marathon-consul/blob/master/main.go#L52-L57

If it connects to a modern marathon, it won't set up the request handler.

I guess it should do both no matter what, not if/else