search

CiscoDevNet / FMCAnsible

GNU General Public License v3.0
21 stars 25 forks source link

createMultipleURLObject does not create facts and documentation needs updating and idempotent #64

Open scottenwright opened 8 months ago

scottenwright commented 8 months ago

  1. When calling createMultipleURLObject with mutliple items facts for the objects are not created like createMultipleNetworkObject does. Sample:

    • name: Execute 'createMultipleURLObject' operation cisco.fmcansible.fmc_configuration: operation: "createMultipleURLObject" data:
      • type: Url name: UrlObject110111 description: url object 1 url: http://wwwin.cisco.com
      • type: Url name: UrlObject110121 description: url object 2 url: http://www.google.com path_params: domainUUID: "{{ domain[0].uuid }}" query_params: bulk: true

  2. The documentation shows the data filed without the dashes and ansible produces runtime warnings about duplicate values.

  3. If the objects bring created already exist with the same values error is reported, shouldn't this be idempotent e.g. it can be run multiple times with the same result:

fatal: [fmcrestapisandbox.cisco.com]: FAILED! => {"changed": false, "msg": "Server returned an error trying to execute createMultipleURLObject operation. Status code: 400. Server response: The object name UrlObject110111 already exists. Enter a new name."}