CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

Added the TCP session rules and match fragment to aci_filter_entry module #426

Closed sajagana closed 1 year ago

sajagana commented 1 year ago

Note:

Added the TCP session rules and match fragment to the aci_filter_entry module also included the Source Port of the TCP/UDP protocol.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 12.00% and project coverage change: -54.44 :warning:

Comparison is base (fc38459) 90.50% compared to head (2de7051) 36.07%.

:exclamation: Current head 2de7051 differs from pull request most recent head bcc676d. Consider uploading reports for the commit bcc676d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #426 +/- ## =========================================== - Coverage 90.50% 36.07% -54.44% =========================================== Files 169 169 Lines 7469 7499 +30 Branches 1088 1100 +12 =========================================== - Hits 6760 2705 -4055 - Misses 599 4794 +4195 + Partials 110 0 -110 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `?` | | | sanity | `36.07% <12.00%> (-0.18%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/CiscoDevNet/ansible-aci/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/modules/aci\_l3out\_bgp\_peer.py](https://codecov.io/gh/CiscoDevNet/ansible-aci/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9iZ3BfcGVlci5weQ==) | `17.85% <0.00%> (-80.90%)` | :arrow_down: | | [plugins/modules/aci\_filter\_entry.py](https://codecov.io/gh/CiscoDevNet/ansible-aci/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9maWx0ZXJfZW50cnkucHk=) | `18.60% <2.43%> (-72.17%)` | :arrow_down: | | [plugins/module\_utils/constants.py](https://codecov.io/gh/CiscoDevNet/ansible-aci/pull/426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | ... and [146 files with indirect coverage changes](https://codecov.io/gh/CiscoDevNet/ansible-aci/pull/426/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.