search

CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

434 test coverage improvements #454

Closed akinross closed 1 year ago

akinross commented 1 year ago

fixes #434

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 17.02% and project coverage change: -55.26% :warning:

Comparison is base (1259294) 90.94% compared to head (e7f3fbc) 35.68%.

:exclamation: Current head e7f3fbc differs from pull request most recent head 1dcc93b. Consider uploading reports for the commit 1dcc93b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #454 +/- ## =========================================== - Coverage 90.94% 35.68% -55.26% =========================================== Files 180 180 Lines 8187 8176 -11 Branches 1214 1208 -6 =========================================== - Hits 7446 2918 -4528 - Misses 627 5258 +4631 + Partials 114 0 -114 ``` | Flag | Coverage Δ | | |---|---|---| | integration | `?` | | | sanity | `35.68% <17.02%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/module\_utils/aci.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvYWNpLnB5) | `11.40% <0.00%> (-63.01%)` | :arrow_down: | | [plugins/modules/aci\_bulk\_static\_binding\_to\_epg.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9idWxrX3N0YXRpY19iaW5kaW5nX3RvX2VwZy5weQ==) | `19.56% <0.00%> (-79.38%)` | :arrow_down: | | [plugins/modules/aci\_config\_snapshot.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9jb25maWdfc25hcHNob3QucHk=) | `30.00% <0.00%> (-63.11%)` | :arrow_down: | | [plugins/modules/aci\_encap\_pool\_range.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9lbmNhcF9wb29sX3JhbmdlLnB5) | `22.85% <ø> (-64.47%)` | :arrow_down: | | [.../modules/aci\_interface\_policy\_leaf\_policy\_group.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X2xlYWZfcG9saWN5X2dyb3VwLnB5) | `26.66% <ø> (-68.42%)` | :arrow_down: | | [plugins/modules/aci\_interface\_policy\_ospf.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X29zcGYucHk=) | `30.76% <0.00%> (-43.31%)` | :arrow_down: | | [plugins/modules/aci\_l3out\_bgp\_peer.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9iZ3BfcGVlci5weQ==) | `18.51% <0.00%> (-80.30%)` | :arrow_down: | | [...ins/modules/aci\_l3out\_logical\_interface\_profile.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9sb2dpY2FsX2ludGVyZmFjZV9wcm9maWxlLnB5) | `44.44% <ø> (-55.56%)` | :arrow_down: | | [...aci\_l3out\_logical\_interface\_profile\_ospf\_policy.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9sb2dpY2FsX2ludGVyZmFjZV9wcm9maWxlX29zcGZfcG9saWN5LnB5) | `42.10% <ø> (-57.90%)` | :arrow_down: | | [plugins/modules/aci\_l3out\_static\_routes.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9zdGF0aWNfcm91dGVzLnB5) | `31.25% <0.00%> (-68.75%)` | :arrow_down: | | ... and [10 more](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | | ... and [138 files with indirect coverage changes](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/454/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 1 year ago

"aci_config_snapshot" and "aci rest" still need to be improved

Discussion needed regarding import statement testing in general and certs for failure on aci_config_snapshot

akinross commented 1 year ago

Other than glaxy error it looks good.

@anvitha-jain this is error related to change log file which I have not touched in this PR. Seems like a new check has been added that previously wasn't triggered. Should we track and resolve this in separate issue/PR?