CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

Added policy groups for spine interface and missing policy groups on leaf interface. #462

Closed anvitha-jain closed 1 year ago

anvitha-jain commented 1 year ago

solves #384

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 98.92% and project coverage change: +3.77% :tada:

Comparison is base (09761ce) 92.74% compared to head (1e6d79c) 96.52%. Report is 11 commits behind head on master.

:exclamation: Current head 1e6d79c differs from pull request most recent head c580636. Consider uploading reports for the commit c580636 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #462 +/- ## ========================================== + Coverage 92.74% 96.52% +3.77% ========================================== Files 180 183 +3 Lines 8176 8430 +254 Branches 1208 1248 +40 ========================================== + Hits 7583 8137 +554 + Misses 524 222 -302 - Partials 69 71 +2 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `94.52% <97.84%> (+0.28%)` | :arrow_up: | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.38% <26.97%> (-0.31%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/modules/aci\_interface\_policy\_lldp.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X2xsZHAucHk=) | `100.00% <ø> (+50.00%)` | :arrow_up: | | [plugins/modules/aci\_interface\_policy\_ospf.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X29zcGYucHk=) | `100.00% <ø> (ø)` | | | [...ugins/modules/aci\_interface\_policy\_port\_channel.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X3BvcnRfY2hhbm5lbC5weQ==) | `100.00% <ø> (+68.62%)` | :arrow_up: | | [plugins/modules/aci\_maintenance\_policy.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9tYWludGVuYW5jZV9wb2xpY3kucHk=) | `97.87% <94.44%> (+52.41%)` | :arrow_up: | | [.../modules/aci\_interface\_policy\_leaf\_policy\_group.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X2xlYWZfcG9saWN5X2dyb3VwLnB5) | `98.94% <97.14%> (-1.06%)` | :arrow_down: | | [...dules/aci\_interface\_policy\_leaf\_fc\_policy\_group.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9pbnRlcmZhY2VfcG9saWN5X2xlYWZfZmNfcG9saWN5X2dyb3VwLnB5) | `97.91% <97.91%> (ø)` | | | [plugins/module\_utils/constants.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [plugins/modules/aci\_dhcp\_relay.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9kaGNwX3JlbGF5LnB5) | `100.00% <100.00%> (ø)` | | | [plugins/modules/aci\_dhcp\_relay\_provider.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9kaGNwX3JlbGF5X3Byb3ZpZGVyLnB5) | `100.00% <100.00%> (+2.12%)` | :arrow_up: | | [...ugins/modules/aci\_fabric\_interface\_policy\_group.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9mYWJyaWNfaW50ZXJmYWNlX3BvbGljeV9ncm91cC5weQ==) | `100.00% <100.00%> (ø)` | | | ... and [10 more](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/462/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.