search

CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[minor_changes] Added BFD Multihop Interface policy (bfdMhIfPol) class. #492

Closed anvitha-jain closed 11 months ago

codecov[bot] commented 1 year ago

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (910e70d) 96.30% compared to head (832f485) 35.32%. Report is 69 commits behind head on master.

Files Patch % Lines
...odules/aci_l3out_bfd_multihop_interface_profile.py 33.33% 30 Missing :warning:
plugins/modules/aci_l3out_bfd_interface_profile.py 34.09% 29 Missing :warning:
plugins/modules/aci_bfd_multihop_node_policy.py 34.88% 28 Missing :warning:
plugins/modules/aci_interface_policy_bfd.py 34.88% 28 Missing :warning:
...ugins/modules/aci_interface_policy_bfd_multihop.py 34.88% 28 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #492 +/- ## =========================================== - Coverage 96.30% 35.32% -60.99% =========================================== Files 210 230 +20 Lines 9720 10610 +890 Branches 1447 1591 +144 =========================================== - Hits 9361 3748 -5613 - Misses 277 6862 +6585 + Partials 82 0 -82 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/492/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/492/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/492/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.32% <34.40%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 1 year ago

please fix sanity checks

gmicol commented 11 months ago

is part of issue #126