CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[minor_change] add support for configuration of system banner and ali… #499

Closed akinross closed 1 year ago

akinross commented 1 year ago

…as with aci_system_banner module

This is a single module (aci_pre_login_banner) from a larger PR of tim cragg #419

Splitting up the module for easier review

codecov[bot] commented 1 year ago

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (96dddfe) 96.52% compared to head (27465c8) 35.40%. Report is 7 commits behind head on master.

:exclamation: Current head 27465c8 differs from pull request most recent head e5d6502. Consider uploading reports for the commit e5d6502 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #499 +/- ## =========================================== - Coverage 96.52% 35.40% -61.12% =========================================== Files 183 187 +4 Lines 8479 8626 +147 Branches 1265 1278 +13 =========================================== - Hits 8184 3054 -5130 - Misses 222 5572 +5350 + Partials 73 0 -73 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.40% <46.93%> (+0.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/module\_utils/constants.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [plugins/modules/aci\_l3out\_logical\_node\_profile.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9sb2dpY2FsX25vZGVfcHJvZmlsZS5weQ==) | `48.48% <ø> (-51.52%)` | :arrow_down: | | [plugins/modules/aci\_snmp\_user.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9zbm1wX3VzZXIucHk=) | `45.45% <0.00%> (-54.55%)` | :arrow_down: | | [plugins/modules/aci\_bgp\_best\_path\_policy.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9iZ3BfYmVzdF9wYXRoX3BvbGljeS5weQ==) | `51.51% <51.51%> (ø)` | | | [plugins/modules/aci\_system\_banner.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9zeXN0ZW1fYmFubmVyLnB5) | `48.57% <48.57%> (ø)` | | | [plugins/modules/aci\_bgp\_timers\_policy.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9iZ3BfdGltZXJzX3BvbGljeS5weQ==) | `45.94% <45.94%> (ø)` | | | [plugins/modules/aci\_l3out\_bgp\_protocol\_profile.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9sM291dF9iZ3BfcHJvdG9jb2xfcHJvZmlsZS5weQ==) | `41.02% <41.02%> (ø)` | | ... and [176 files with indirect coverage changes](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/499/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.