CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

Tim cragg access switch policy group #501

Closed akinross closed 1 year ago

akinross commented 1 year ago

This is a single module (aci_access_switch_policy_group) from a larger PR of tim cragg https://github.com/CiscoDevNet/ansible-aci/pull/419

Splitting up the module for easier review

codecov[bot] commented 1 year ago

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (1474956) 96.20% compared to head (489ae9e) 35.40%.

:exclamation: Current head 489ae9e differs from pull request most recent head 91c6149. Consider uploading reports for the commit 91c6149 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #501 +/- ## =========================================== - Coverage 96.20% 35.40% -60.81% =========================================== Files 192 193 +1 Lines 8823 8926 +103 Branches 1307 1334 +27 =========================================== - Hits 8488 3160 -5328 - Misses 261 5766 +5505 + Partials 74 0 -74 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.40% <17.47%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/module\_utils/constants.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [plugins/module\_utils/aci.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvYWNpLnB5) | `11.44% <0.00%> (-63.38%)` | :arrow_down: | | [plugins/modules/aci\_access\_switch\_policy\_group.py](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL2FjaV9hY2Nlc3Nfc3dpdGNoX3BvbGljeV9ncm91cC5weQ==) | `17.00% <17.00%> (ø)` | | ... and [184 files with indirect coverage changes](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/501/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.