CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[ignore] remove 173.36.219.73 from inventory #546

Closed akinross closed 11 months ago

akinross commented 11 months ago

Removing apic from inventory which should not be used anymore by CI

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0e7af57) 96.30% compared to head (f5d9a36) 35.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #546 +/- ## =========================================== - Coverage 96.30% 35.32% -60.99% =========================================== Files 211 211 Lines 9748 9748 Branches 1456 1456 =========================================== - Hits 9388 3443 -5945 - Misses 276 6305 +6029 + Partials 84 0 -84 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/546/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.32% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shrsr commented 11 months ago

Are we replacing this with another APIC?

akinross commented 11 months ago

Check comment

I don't know, but this one is not being used anymore. Also these where both 6.x version so not sure if we need that additional node. Now we still have a 4.x, 5.x and 6.x.