search

CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

Added Modules - fabricPodP, fabricSetupP, Remote Pool & External TEP #558

Closed samiib closed 10 months ago

samiib commented 11 months ago
  1. Added Fabric Pod Profile and Fabric Setup Pod modules including child modules - External TEP and Remote Pool.
  2. Added integration test for Pod Fabric Setup Policy, Pod Profile, External TEP and Remote Pool.
  3. Closes #508
codecov[bot] commented 11 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (7ad2b51) 96.25% compared to head (c93f1e2) 96.40%. Report is 69 commits behind head on master.

Files Patch % Lines
plugins/modules/aci_fabric_pod_external_tep.py 94.28% 1 Missing and 1 partial :warning:
plugins/modules/aci_fabric_pod_remote_pool.py 94.11% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #558 +/- ## ========================================== + Coverage 96.25% 96.40% +0.14% ========================================== Files 211 235 +24 Lines 9807 10796 +989 Branches 1477 1622 +145 ========================================== + Hits 9440 10408 +968 - Misses 281 296 +15 - Partials 86 92 +6 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/558/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `94.85% <93.98%> (+0.24%)` | :arrow_up: | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/558/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.36% <48.12%> (+0.25%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 11 months ago

Please also fix sanity issues