CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[minor_change] Add support for configuration of fabric management acc… #585

Closed akinross closed 9 months ago

akinross commented 10 months ago

…ess policies in aci_fabric_management_access

Test are depending on two PRs to be merged #586 and #587. Cherry pick the below commit to test:

https://github.com/CiscoDevNet/ansible-aci/pull/586/commits/682e80493ea1b1c48f8bb28905f51b9fb028afe3 https://github.com/CiscoDevNet/ansible-aci/pull/587/commits/d5f430db64866bca8bbcb5c0366628697e6c2ec2

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 42.55319% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 35.69%. Comparing base (95a9473) to head (1c14059). Report is 7 commits behind head on master.

Files Patch % Lines
plugins/modules/aci_fabric_management_access.py 31.48% 37 Missing :warning:
...dules/aci_fabric_management_access_https_cipher.py 50.00% 16 Missing :warning:
plugins/modules/aci_fabric_wide_settings.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #585 +/- ## ========================================== + Coverage 35.67% 35.69% +0.02% ========================================== Files 250 252 +2 Lines 11415 11526 +111 Branches 1721 1744 +23 ========================================== + Hits 4072 4114 +42 - Misses 7343 7412 +69 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/585/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/585/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.69% <42.55%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.