CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[minor_change] Add support for key ring configuration in aci_aaa_key_ring #587

Closed akinross closed 9 months ago

akinross commented 10 months ago

part of #583

testing depending on certificate authority cherry-pick commit when you want to run tests.

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 38.00000% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 35.67%. Comparing base (1bd88f0) to head (73b4c84).

Files Patch % Lines
plugins/modules/aci_aaa_key_ring.py 36.95% 29 Missing :warning:
plugins/module_utils/aci.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #587 +/- ## ======================================= Coverage 35.66% 35.67% ======================================= Files 249 250 +1 Lines 11366 11415 +49 Branches 1715 1721 +6 ======================================= + Hits 4054 4072 +18 - Misses 7312 7343 +31 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/587/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/587/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.67% <38.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.