search

CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[minor change] Added modules and tests for missing 1-N children for BD. #600

Closed samiib closed 9 months ago

samiib commented 10 months ago
  1. Added modules and tests for 1-N Relationships for BD.
    • bd_to_netflow_monitor_policy
    • bd_rogue_exception_mac
  2. Added, missing clean-up in bd_to_l3out tests.
  3. Please note this PR is reliant on the merging of PR #582

Closes #534

codecov[bot] commented 10 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 35.61%. Comparing base (f3b017f) to head (a7c0d97).

Files Patch % Lines
plugins/modules/aci_bd_rogue_exception_mac.py 50.00% 15 Missing :warning:
...lugins/modules/aci_bd_to_netflow_monitor_policy.py 50.00% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #600 +/- ## =========================================== - Coverage 96.30% 35.61% -60.69% =========================================== Files 241 243 +2 Lines 11024 11084 +60 Branches 1658 1664 +6 =========================================== - Hits 10617 3948 -6669 - Misses 308 7136 +6828 + Partials 99 0 -99 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/600/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/600/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.61% <50.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.