search

CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
132 stars 91 forks source link

Update Spine Access Policies modules #624

Closed gmicol closed 3 months ago

gmicol commented 4 months ago

from PR #388

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 46.66667% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 35.72%. Comparing base (cfe2d82) to head (72a73ee).

Files Patch % Lines
plugins/modules/aci_node_block.py 39.47% 23 Missing :warning:
...ins/modules/aci_access_spine_interface_selector.py 47.22% 19 Missing :warning:
...lugins/modules/aci_access_spine_switch_selector.py 47.22% 19 Missing :warning:
...gins/modules/aci_access_spine_interface_profile.py 53.33% 14 Missing :warning:
...spine_interface_profile_to_spine_switch_profile.py 53.33% 14 Missing :warning:
plugins/modules/aci_access_spine_switch_profile.py 53.33% 14 Missing :warning:
...ns/modules/aci_access_port_block_to_access_port.py 0.00% 6 Missing :warning:
plugins/modules/aci_switch_leaf_selector.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #624 +/- ## ========================================== + Coverage 35.52% 35.72% +0.19% ========================================== Files 259 265 +6 Lines 11919 12127 +208 Branches 1810 1833 +23 ========================================== + Hits 4234 4332 +98 - Misses 7685 7795 +110 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/624/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/624/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.72% <46.66%> (+0.19%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gmicol commented 3 months ago

@anvitha-jain The Leaf Access Policies module already exist. Only the Spine ones were missing. So no need for renaming.