CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

[minor_change] Added Suppress Previous option to reduce the number of API calls. #636

Closed samiib closed 7 months ago

samiib commented 7 months ago
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 6.25000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 35.68%. Comparing base (faff94c) to head (a68a92c). Report is 1 commits behind head on master.

:exclamation: Current head a68a92c differs from pull request most recent head e1d87f8. Consider uploading reports for the commit e1d87f8 to get more accurate results

Files Patch % Lines
plugins/module_utils/aci.py 6.25% 15 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #636 +/- ## ========================================== - Coverage 35.70% 35.68% -0.02% ========================================== Files 265 265 Lines 12133 12141 +8 Branches 1835 1837 +2 ========================================== + Hits 4332 4333 +1 - Misses 7801 7808 +7 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/636/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.68% <6.25%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shrsr commented 7 months ago

Is this PR part of the issue #609?

samiib commented 7 months ago

Is this PR part of the issue #609?

Yes, thanks for linking sorry I may have forgotten to link it this time. I still got to do another PR so can't link just yet.