search

CiscoDevNet / ansible-aci

Cisco ACI Ansible Collection
https://galaxy.ansible.com/cisco/aci
GNU General Public License v3.0
143 stars 97 forks source link

fix: Correct vPC member side (DCNE-93) #663

Closed timcragg closed 1 month ago

timcragg commented 5 months ago

Minor bugfix - the l3extMember object uses side instead of name to build the DN, so the module should configure the side attribute instead of the name (I believe the name attribute is left as null if you build an l3extMember object through the APIC GUI). Closes DCNE-93

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.75%. Comparing base (555a942) to head (a55c799). Report is 23 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (555a942) and HEAD (a55c799). Click for more details.

HEAD has 15 uploads less than BASE | Flag | BASE (555a942) | HEAD (a55c799) | |------|------|------| |unit|8|0| |integration|1|0| |sanity|10|4|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #663 +/- ## =========================================== - Coverage 58.46% 35.75% -22.72% =========================================== Files 269 266 -3 Lines 12352 12165 -187 Branches 1862 1837 -25 =========================================== - Hits 7222 4349 -2873 - Misses 5002 7816 +2814 + Partials 128 0 -128 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/663/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `35.75% <ø> (ø)` | | | [unit](https://app.codecov.io/gh/CiscoDevNet/ansible-aci/pull/663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

samiib commented 3 months ago

@timcragg Hi Tim, just wondering if you are still working on this one or if you have had a chance to look at the PR review comment?