dcnm_image_policy v2: Ready for review

[allenrobel]

Merge order

To avoid merge conflicts, please merge the following PRs in the order below.

1. dcnm_maintenance_mode
2. dcnm_image_policy v2
3. dcnm_image_ugrade v2
4. dcnm_fabric v2

Branch

dcnm_image_policy_v2 created off of branch dcnm_maintenance_mode.

Fixes

• dcnm_image_policy.py:
  • Fixed issue where parameter values for optional parameters were getting deleted if the parameter was not present in the playbook config.

Enhancements

• Updates all dcnm_image_policy support classes to their v2 versions:
  • Log
  • MergeDicts
  • ParamsMergeDefaults
  • ParamsValidate
  • RestSend
• ImagePolicyDelete: Eliminate a call to the controller.

The v2 versions (mainly) remove dependency on AnsibleModule, but also make unit tests easier to write due to abstractions in the Sender() class reducing the need for mocks.

• Adds use of the Sender() classes in sender_dcnm.py and sender_file.py in module_utils/common.
• Uses Api() classes for endpoint resolution and removes ApiEndpoints() class.
• Removes a few unit tests that were made redundant as a result of the changes in this PR.
• Improvements to integration tests by adding query verifications after image policy changes are made.

Caveats

• None. The changes are backward compatible with the current dcnm_image_policy class interfaces and module results returned to the user.