CiscoDevNet / ansible-dcnm

Apache License 2.0
47 stars 37 forks source link

dcnm_image_upgrade v2: Ready for review. #309

Closed allenrobel closed 3 months ago

allenrobel commented 4 months ago

Merge order

To avoid merge conflicts, please merge the following PRs in the order below.

  1. dcnm_maintenance_mode
  2. dcnm_image_policy v2
  3. dcnm_image_ugrade v2
  4. dcnm_fabric v2

Summary

This PR aligns dcnm_image_upgrade with the v2 support libraries.

branch

dcnm_image_upgrade_v2 created off of branch dcnm_image_policy_v2.

Changes

  1. dcnm_image_upgrade.py
    • Refactored into classes Common(), Merged(), Deleted(), Query()
  2. ImagePolicyAction(): replaced with:
    • ImagePolicyAttach()
    • ImagePolicyDetach()
      1. Following are updated to align with v2 support classes
        • ImageStage()
        • ImageValidate()
        • ImageUpgrade()
        • InstallOptions()
        • SwitchIssuDetails() and its subclasses
      2. WaitForControllerDone() new class. Wait for actions to complete on the controller.
      3. UT: All unit tests rewritten and renumbered.
      4. IT: Tests modularized for shorter run times.
allenrobel commented 3 months ago

Closing and using the below PR instead.

https://github.com/CiscoDevNet/ansible-dcnm/pull/315