search

CiscoDevNet / ansible-dcnm

Apache License 2.0
45 stars 32 forks source link

Physical Interface Description of vPC Member Port #51

Open Tessier-Ashp001 opened 3 years ago

Tessier-Ashp001 commented 3 years ago

Possible feature request?

Is it possible to apply a description to a physical interface that is a member of a vPC? There is a description option present for vPC config but this applies to the port-channel itself rather than the member port.

I am following the example:

- name: Create vPC interfaces
  cisco.dcnm.dcnm_interface: &vpc_merge
    fabric: mmudigon-fabric
    state: merged                         # only choose from [merged, replaced, deleted, overridden, query]
    config:
      - name: vpc750                      # should be of the form vpc<port-id>
        type: vpc                         # choose from this list [pc, vpc, sub_int, lo, eth]
        switch:                           # provide switches of vPC pair
          - ["{{ ansible_switch1 }}",
             "{{ ansible_switch2 }}"]
        deploy: true                      # choose from [true, false]
        profile:
          admin_state: true               # choose from [true, false]
          mode: trunk                     # choose from [trunk, access]
          peer1_pcid: 100                 # choose between [Min:1, Max:4096], if not given, will be VPC port-id
          peer2_pcid: 100                 # choose between [Min:1, Max:4096], if not given, will be VPC port-id
          peer1_members:                  # member interfaces on peer 1
            - e1/24
          peer2_members:                  # member interfaces on peer 2
            - e1/24
          pc_mode: 'active'               # choose from ['on', 'active', 'passive']
          bpdu_guard: true                # choose from [true, false, 'no']
          port_type_fast: true            # choose from [true, false]
          mtu: jumbo                      # choose from [default, jumbo]
          peer1_allowed_vlans: none       # choose from [none, all, vlan range]
          peer2_allowed_vlans: none       # choose from [none, all, vlan range]
          peer1_description: "VPC acting as trunk peer1"
          peer2_description: "VPC acting as trunk peer2"

Thanks...

mikewiebe commented 3 years ago

@Tessier-Ashp001 Thanks for raising this issue. We are investigating this option and will reply back soon.

@mmudigon Can you look into this?

mikewiebe commented 3 years ago

Resolved in latest release version

mikewiebe commented 3 years ago

Did not mean to close this. Re-opening.

Tessier-Ashp001 commented 3 years ago

That's brilliant, thanks @mikewiebe !

mikewiebe commented 3 years ago

That's brilliant, thanks @mikewiebe !

@Tessier-Ashp001 I did not mean to close this earlier. This issue is still open as we explore options for this.

mikewiebe commented 3 years ago

@Tessier-Ashp001 Just double checking again... Did you mean to close this issue?

Tessier-Ashp001 commented 3 years ago

Hi @mikewiebe . I did. Now I haven't tested this yet and won't be able to until the weekend, so I'll maybe keep this one open for the moment if that's OK. Just to confirm, it's the latest develop branch that I should use?

Also, do the following variables in the above example now get applied to both the port-channel as well as the member ports, or do I need to define the member ports descriptions elsewhere?:

      peer1_description: "VPC acting as trunk peer1"
      peer2_description: "VPC acting as trunk peer2"

I can't seem to find where the member port descriptions get applied in the dcnm_interface.py file..

Thanks

mikewiebe commented 3 years ago

@Tessier-Ashp001 We have not fixed this yet. I accidentally closed this issue but re-opened it when I realized I had closed the wrong issue. We are still discussing as a team on the best way to handle this request so there is nothing to test at the moment :-).

Sorry for the confusion!

sheshcode commented 1 year ago

Hi All,

Just wondering if there has been any progress or if this issue is still being worked !!!

Thanks