CiscoDevNet / ansible-nd

Cisco ND Ansible Collection
https://galaxy.ansible.com/cisco/nd
GNU General Public License v3.0
4 stars 15 forks source link

Added nd_service.py and nd_service_instance.py modules to manage ND services #53

Closed sajagana closed 1 year ago

sajagana commented 1 year ago

Note:

Local service package import is not supported and the module supported on ND version 2.3+

codecov-commenter commented 1 year ago

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (6bba23d) 34.40% compared to head (febb86d) 37.49%. Report is 9 commits behind head on master.

:exclamation: Current head febb86d differs from pull request most recent head bd1b20d. Consider uploading reports for the commit bd1b20d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #53 +/- ## ========================================== + Coverage 34.40% 37.49% +3.09% ========================================== Files 24 28 +4 Lines 1994 2163 +169 Branches 433 468 +35 ========================================== + Hits 686 811 +125 - Misses 1271 1295 +24 - Partials 37 57 +20 ``` | [Flag](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `37.80% <52.70%> (+3.47%)` | :arrow_up: | | [sanity](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | `22.60% <29.55%> (+0.94%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet) | Coverage Δ | | |---|---|---| | [plugins/module\_utils/constants.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | | | [plugins/module\_utils/nd\_argument\_specs.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvbmRfYXJndW1lbnRfc3BlY3MucHk=) | `100.00% <100.00%> (ø)` | | | [plugins/modules/nd\_setup.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL25kX3NldHVwLnB5) | `95.65% <95.65%> (ø)` | | | [plugins/httpapi/nd.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9odHRwYXBpL25kLnB5) | `38.52% <0.00%> (+0.72%)` | :arrow_up: | | [plugins/modules/nd\_service.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL25kX3NlcnZpY2UucHk=) | `48.78% <48.78%> (ø)` | | | [plugins/module\_utils/nd.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVfdXRpbHMvbmQucHk=) | `28.73% <22.50%> (+5.63%)` | :arrow_up: | | [plugins/modules/nd\_service\_instance.py](https://app.codecov.io/gh/CiscoDevNet/ansible-nd/pull/53?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=CiscoDevNet#diff-cGx1Z2lucy9tb2R1bGVzL25kX3NlcnZpY2VfaW5zdGFuY2UucHk=) | `38.98% <38.98%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.