search

CiscoDevNet / csmp-agent-lib

CiscoDevNet Opensource CSMP-Agent Library (OpenCSMP)
https://github.com/CiscoDevNet/csmp-agent-lib
Apache License 2.0
4 stars 3 forks source link

Rework the OLAL timer interface #21

Open silabs-ThibautC opened 3 weeks ago

silabs-ThibautC commented 3 weeks ago

The OSAL API currently exposes a trickle timer API. All the logic specific to the tickle timers is generic and does not need to be in the abstraction layer. The current implementation will lead to code duplications and will force future developers to understand what's a trickle timer and how it works. I suggest moving that logic out of the OSAL and exposing a generic timer API.

  1. define and implement a new osal_start_timer(duration, handler)
  2. move the tickle logic out of osal_linux.c and osal_freertos.c
paduffy commented 3 weeks ago

Agreed. I've pointed this out several times in the past.