CiscoDevNet / csmp-agent-lib

CiscoDevNet Opensource CSMP-Agent Library (OpenCSMP)
https://github.com/CiscoDevNet/csmp-agent-lib
Apache License 2.0
4 stars 3 forks source link

Implement Silicon Labs EFR32 Wi-SUN support #22

Open ismilak opened 1 month ago

ismilak commented 1 month ago

Significant features and modifications:

ismilak commented 1 month ago

Tested all targets on all possible platforms:

Test scenario

ismilak commented 3 weeks ago

@ismilak: I’ve reviewed some portion of the overall changes in this PR#22.

Changes look good under and the build/makefile udpates

osal/efr32_wisun
osal/freertos
osal/linux

Changes under /src are in review.

Changes under /sample, we see a lot of refactorization of the sample application code into multiple files. Per our last discussion we agreed to move only the TLV GET/PUT implementations to a separate file(now moved under tlvs/_tlvs.c), while keeping the rest in the original sample/CsmpAgentLib_sample.[ch]

sample_tlvs.[ch]
sample_util.[ch]
tlvs/efr32_wisun_tlvs.c
tlvs/freertos_tlvs.c
tlvs/linux_tlvs.c

Yep, let me explain the purposes of the source files.

The files are created to separate APIs and function implementations based on their functionality. I think what we can change to reduce the count of the files in sample/ directory:

I recommend to keep as it is to have this kind of architecture for future improvements and to reduce the length of sample source files.