search

CiscoDevNet / devnet-express-code-samples

Archived: This repository holds code samples for DevNet Express DNA Track
47 stars 102 forks source link

Needs Spark rename updates #26

Open annegentle opened 6 years ago

annegentle commented 6 years ago

Spark renamed to Webex Teams, and use ACCESS_TOKEN instead of SPARK_TOKEN - plus look for sparkbot.io renamed to webex.bot, and developer.ciscospark.com redirecting to developer.webex.com.

annegentle commented 6 years ago

Hey Ashley (@aroach ) I did the content changes in the devnet-express repo, but haven't circled back here. Can you take it?

aroach commented 6 years ago

@annegentle are we only changing ACCESS_TOKEN -- looks like there are a lot of function names and variables with spark in them as well...

annegentle commented 6 years ago

Yeah I’m working towards removing Spark from variable names as well, using Webex or Webex Teams with matching capitalization or kebab-case as needed... see what you think of that as you dive in.

annegentle commented 6 years ago

See what you think of this PR for the DCI code: https://github.com/CiscoDevNet/devnet-express-dci-code-samples/pull/6

aroach commented 6 years ago

ok, what about filenames too? such as spark-room-easy.py

annegentle commented 6 years ago

That's what I'm working through today... trying to move those to webex-teams-room-easy.py for example. Will require testing, yeah.

aroach commented 6 years ago

I think i got all of the changes except the meraki mission. See PR #27