search

CiscoDevNet / iPSK-Manager

Identity PSK (IPSK) Manager for Cisco ISE provides an example of how to manage the full Life Cycle of Wi-Fi Pre Shared Keys for supported Hardware/Software through Cisco ISE.
Apache License 2.0
30 stars 16 forks source link

Add pinpoint for CSV import failures (i.e. illegal character at line X) #30

Closed joe-catanzaro closed 9 months ago

joe-catanzaro commented 10 months ago

Is your feature request related to a problem? Please describe. Not necessarily a problem, as the issue I originally reported has been fixed. However, in my implementation there are a lot of users using the portal that are not technical. When they go to import a CSV, sometimes it might fail with an illegal character or some other error, but there's no description to the user of where to look for that error. This seems to be more common when copying and pasting values into the CSV from other sources that may have formatting or other funky unexpected attributes.

Describe the solution you'd like It would be nice to have the failure read out what line the issue is at. I.e. illegal character at line 20, even better if it could tell you the error is in field "fullname". Having an option to either stop the import at the first error or log the error and continue importing would be cool too.

Describe alternatives you've considered No real workaround, other than trial and error for the user or myself with the file.

Additional context Add any other context or screenshots about the feature request here.

ciesinsn commented 9 months ago

I'll take a look at this, top of my head I don't think this will be a lot of work to implement.

ciesinsn commented 9 months ago

@joe-catanzaro The way the code is I couldn't give the exact character that is causing a issue because it isn't returned in the check. But, I added code to at least pinpoint the lines the issue is on to help troubleshoot any upload issues.

joe-catanzaro commented 9 months ago

@ciesinsn awesome! super thankful for the collaboration.

joe-catanzaro commented 4 months ago

@ciesinsn I've actually discovered something else with this. It looks like the fix only applied to the admin portal. I have users running on a separate operator portal that's experiencing the illegal character issue (assuming it's the underscore in the email again) but when I upload the same file to the admin portal it works fine.

ciesinsn commented 4 months ago

I looked at the commit linked to this issue and, yes, it was only fixed in admin portal. Can you make a new enhancement issue to port the enhancement from commit 458bc66 and issue #30 to the sponsor portal pages. Thanks!

joe-catanzaro commented 4 months ago

Thanks Nick! Issue 46 created.

From: Nick Ciesinski @.> Sent: Wednesday, May 1, 2024 9:21 AM To: CiscoDevNet/iPSK-Manager @.> Cc: Joe Catanzaro @.>; Mention @.> Subject: [EXT] Re: [CiscoDevNet/iPSK-Manager] Add pinpoint for CSV import failures (i.e. illegal character at line X) (Issue #30)

ATTENTION: This email originated from outside of the organization. Please do not open any attachments or click any links unless you recognize the sender and know the content is safe.

I looked at the commit linked to this issue and, yes, it was only fixed in admin portal. Can you make a new enhancement issue to port the enhancement from commit 458bc66https://urldefense.com/v3/__https:/github.com/CiscoDevNet/iPSK-Manager/commit/458bc6633bd108a6cbe0f6a2f24a9f997202bce3__;!!LVMHySo!mtqwJVtCcigWQhuVQ8e0isE-puTnUWM6Ekg0djvCQMjijAKS-9fKfjRjmdcO2YMOG-kr17nTZ-iElkptiL6APTK3r0U2$ and issue #30https://urldefense.com/v3/__https:/github.com/CiscoDevNet/iPSK-Manager/issues/30__;!!LVMHySo!mtqwJVtCcigWQhuVQ8e0isE-puTnUWM6Ekg0djvCQMjijAKS-9fKfjRjmdcO2YMOG-kr17nTZ-iElkptiL6APb4trq4c$ to the sponsor portal pages. Thanks!

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/CiscoDevNet/iPSK-Manager/issues/30*issuecomment-2088452942__;Iw!!LVMHySo!mtqwJVtCcigWQhuVQ8e0isE-puTnUWM6Ekg0djvCQMjijAKS-9fKfjRjmdcO2YMOG-kr17nTZ-iElkptiL6APXvumW6x$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/BDZS32Y65RRLS3VYO6NHNPLZADT4VAVCNFSM6AAAAAA752FHICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGQ2TEOJUGI__;!!LVMHySo!mtqwJVtCcigWQhuVQ8e0isE-puTnUWM6Ekg0djvCQMjijAKS-9fKfjRjmdcO2YMOG-kr17nTZ-iElkptiL6APXuJo2KE$. You are receiving this because you were mentioned.Message ID: @.***>

====================================================================== The information in this email is confidential, and is intended solely for the addressee(s). Access to this email by anyone else is unauthorized and therefore prohibited. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited and may be unlawful.