CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

Added relation_to_instance_profile and relation_to_route_control_profile - resource and data-source files (DCNE-153) #1204

Closed sajagana closed 3 months ago

samiib commented 6 months ago

There is a fail test for relation_to_route_control_profile data source. Do you have this error happening locally or is it a CI issue? Error: Failed to read aci_relation_to_route_control_profile data source

I think this is a new test that is consistently failing. I re-ran the CI and its correctly picking up the failed test. Unless there is some environment difference because the CI is run on Ubuntu latest.

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 88.53616% with 130 lines in your changes are missing coverage. Please review.

Project coverage is 87.16%. Comparing base (6f45104) to head (eb2a16b).

Files Patch % Lines
...vider/resource_aci_relation_to_instance_profile.go 85.15% 35 Missing and 18 partials :warning:
.../resource_aci_relation_to_route_control_profile.go 85.75% 35 Missing and 18 partials :warning:
...er/data_source_aci_relation_to_instance_profile.go 91.30% 6 Missing and 2 partials :warning:
...ta_source_aci_relation_to_route_control_profile.go 91.66% 6 Missing and 2 partials :warning:
...rnal/provider/resource_aci_l3out_consumer_label.go 95.48% 4 Missing and 4 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1204 +/- ## ========================================== + Coverage 87.03% 87.16% +0.13% ========================================== Files 43 47 +4 Lines 11223 12353 +1130 ========================================== + Hits 9768 10768 +1000 - Misses 991 1077 +86 - Partials 464 508 +44 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.