CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

Generated resource and datasource for fvSiteAssociated and fvRemoteId #1233

Open abrahammughal opened 5 months ago

abrahammughal commented 5 months ago

Fixes #1224

akinross commented 5 months ago

CI failing on go generate, make sure you run go generate before you push the changes. This ensures that you have not made any manual changes that the go generate command will wipe away.

Please use [ignore] tag for commits that are not related text that need to be in release notes / changes. So Generated resource and datasource for fvSiteAssociated would be a minor_change. Created fvRemoteId class would be a minor_change. The other would be ignore.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 86.19173% with 157 lines in your changes missing coverage. Please review.

Project coverage is 84.18%. Comparing base (e45252b) to head (5b6255c). Report is 9 commits behind head on master.

Files Patch % Lines
internal/provider/resource_aci_associated_site.go 83.94% 45 Missing and 25 partials :warning:
...l/provider/resource_aci_remote_site_id_mappings.go 84.91% 45 Missing and 25 partials :warning:
...ternal/provider/data_source_aci_associated_site.go 92.85% 6 Missing and 2 partials :warning:
...rovider/data_source_aci_remote_site_id_mappings.go 93.33% 6 Missing and 2 partials :warning:
internal/provider/utils.go 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1233 +/- ## ========================================== + Coverage 84.05% 84.18% +0.13% ========================================== Files 61 65 +4 Lines 17940 19076 +1136 ========================================== + Hits 15080 16060 +980 - Misses 2054 2156 +102 - Partials 806 860 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 4 months ago

tests are failing, please check that all test are working