CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

1165 error on create existing #1241

Closed akinross closed 4 months ago

akinross commented 5 months ago

fixes #1165

requires #1223 to be merged first and then needs rebase

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 61.11111% with 322 lines in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (bd77190) to head (91098d8).

Files Patch % Lines
internal/provider/resource_aci_endpoint_tag_ip.go 58.62% 8 Missing and 4 partials :warning:
internal/provider/resource_aci_endpoint_tag_mac.go 58.62% 8 Missing and 4 partials :warning:
...ci_external_management_network_instance_profile.go 58.62% 8 Missing and 4 partials :warning:
...resource_aci_external_management_network_subnet.go 58.62% 8 Missing and 4 partials :warning:
...rnal/provider/resource_aci_l3out_consumer_label.go 58.62% 8 Missing and 4 partials :warning:
...al/provider/resource_aci_l3out_node_sid_profile.go 58.62% 8 Missing and 4 partials :warning:
...rnal/provider/resource_aci_l3out_provider_label.go 58.62% 8 Missing and 4 partials :warning:
...provider/resource_aci_l3out_redistribute_policy.go 58.62% 8 Missing and 4 partials :warning:
...al/provider/resource_aci_netflow_monitor_policy.go 58.62% 8 Missing and 4 partials :warning:
...nal/provider/resource_aci_netflow_record_policy.go 58.62% 8 Missing and 4 partials :warning:
... and 20 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1241 +/- ## ========================================== - Coverage 85.24% 84.05% -1.19% ========================================== Files 61 61 Lines 17263 17940 +677 ========================================== + Hits 14715 15080 +365 - Misses 1848 2054 +206 - Partials 700 806 +106 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.