CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
84 stars 99 forks source link

1165 error on create existing #1241

Open akinross opened 1 week ago

akinross commented 1 week ago

fixes #1165

requires #1223 to be merged first and then needs rebase

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 93.04813% with 65 lines in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (5f5cc63) to head (a6723ae).

Files Patch % Lines
...rovider/data_source_aci_endpoint_security_group.go 97.45% 6 Missing and 2 partials :warning:
...r/data_source_aci_relation_to_consumed_contract.go 91.66% 6 Missing and 2 partials :warning:
...der/data_source_aci_relation_to_contract_master.go 91.30% 6 Missing and 2 partials :warning:
...r/data_source_aci_relation_to_imported_contract.go 91.66% 6 Missing and 2 partials :warning:
.../data_source_aci_relation_to_intra_epg_contract.go 91.30% 6 Missing and 2 partials :warning:
...r/data_source_aci_relation_to_provided_contract.go 92.00% 6 Missing and 2 partials :warning:
...ider/data_source_aci_relation_to_taboo_contract.go 91.30% 6 Missing and 2 partials :warning:
internal/provider/provider.go 79.41% 6 Missing and 1 partial :warning:
internal/provider/resource_aci_annotation.go 89.47% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1241 +/- ## ========================================== - Coverage 87.03% 84.33% -2.70% ========================================== Files 43 57 +14 Lines 11223 16620 +5397 ========================================== + Hits 9768 14017 +4249 - Misses 991 1900 +909 - Partials 464 703 +239 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.