CiscoDevNet / terraform-provider-aci

Terraform Cisco ACI provider
https://registry.terraform.io/providers/CiscoDevNet/aci/latest/docs
Mozilla Public License 2.0
91 stars 101 forks source link

Add Resource and Datasource for Netflow Exporter Policy (netflowExporterPol) (DCNE-154) #1242

Closed gmicol closed 2 months ago

gmicol commented 4 months ago

Resolves #1211

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 91.58249% with 100 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (9465913) to head (a60dbbc).

Files with missing lines Patch % Lines
...l/provider/resource_aci_netflow_exporter_policy.go 89.34% 49 Missing and 29 partials :warning:
...rovider/data_source_aci_netflow_exporter_policy.go 94.04% 7 Missing and 3 partials :warning:
internal/provider/resource_aci_application_epg.go 88.88% 6 Missing :warning:
...l/provider/resource_aci_endpoint_security_group.go 81.81% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1242 +/- ## ========================================== + Coverage 85.08% 85.25% +0.17% ========================================== Files 100 102 +2 Lines 36784 37812 +1028 ========================================== + Hits 31298 32238 +940 - Misses 4062 4118 +56 - Partials 1424 1456 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akinross commented 2 months ago

There are tests failing please also check CI

akinross commented 2 months ago

There are still a lot of open comments, are you still working on those? Could you please respond to those?